[#CORE-3109] Transactions : LocalTransaction, JCATransaction, JTATransaction should be for JPOX, and then have a single JDOTransaction that wraps whatever is used by the ObjectManager - DataNucleus JIRA

JPOX Core (ARCHIVED)

Transactions : LocalTransaction, JCATransaction, JTATransaction should be for JPOX, and then have a single JDOTransaction that wraps whatever is used by the ObjectManager

Created: 12/Dec/06 02:57 PM Updated: 04/Jan/08 07:39 AM Resolved: 23/Mar/07 09:03 PM

Component/s:

Code Structure

Affects Version/s:

None

Fix Version/s:

1.2.0-beta-2

Description

« Hide

We currently have
org.jpox.store.rdbms.LocalTransaction
org.jpox.store.rdbms.JCATransaction
org.jpox.store.rdbms.JTATransaction
org.jpox.store.db4o.LocalTransaction
and all are tied to JDO (implementing javax.jdo.Transaction, and throwing JDOExceptions).

This should be changed so that they throw JPOXExceptions, and dont implement javax.jdo.Transaction.
We then have org.jpox.jdo.JDOTransactionImpl that takes in the ObjectManager and simply wraps the Transaction methods for JDO, catching the JPOXExceptions and throwing JDOTransactions. This is what the org.jpox.jpa.EntityTransactionImpl does now

Sort Order:

[ Permalink | « Hide ]

Erik Bengtson added a comment - 29/Jan/07 11:20 AM

This should be done after http://www.jpox.org/servlet/jira/browse/CORE-3148 and together with spliting the ObjectManager to the PersistenceManager. PersistenceManager should be only a reference to the ObjectManager and not extend it. Is there any known reason , besides time, that PersistenceManager extends ObjectManager?

[ Permalink | « Hide ]

Andy Jefferson added a comment - 31/Jan/07 08:05 PM

Uncomment it and see what happens. More changes are needed ... in queries for example (and i'm not touching that code for reasons you know very well ;-) )

[ Permalink | « Hide ]

Andy Jefferson added a comment - 12/Mar/07 12:38 PM

Erik,
I assume this issue is now complete with code in CVS?

[ Permalink | « Hide ]

Andy Jefferson added a comment - 23/Mar/07 09:03 PM

Marking as fixed since the structure is in place and since there are other transaction JIRAs around here we can load anything else into the others